ndimiduk edited a comment on pull request #3969:
URL: https://github.com/apache/hbase/pull/3969#issuecomment-1006012719


   > Are there any shell scripts which might have called the old `dump()` 
static method you removed?
   
   Oh, nice thinking. Yeah, looks like `admin.rb`.
   
   ```
   $ find . -type f ! -iname '*.java' -exec grep -iIn 'ZKUtil' {} \+ | grep dump
   ./hbase-shell/target/classes/hbase/admin.rb:480:      
org.apache.hadoop.hbase.zookeeper.ZKUtil.dump(@zk_wrapper)
   ./hbase-shell/src/main/ruby/hbase/admin.rb:480:      
org.apache.hadoop.hbase.zookeeper.ZKUtil.dump(@zk_wrapper)
   ```
   
   _sorry for the edits_
   
   > Is it possible to deprecate the old method and have it just call the new 
location of the utility in the `ZKDump` class instead?
   
   I could, but why? You want to protect users who are calling into an 
IA.Private class?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to