wchevreuil commented on a change in pull request #4009:
URL: https://github.com/apache/hbase/pull/4009#discussion_r779660193
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/region/MasterRegionFactory.java
##########
@@ -83,6 +84,7 @@
public static final byte[] PROC_FAMILY = Bytes.toBytes("proc");
private static final TableDescriptor TABLE_DESC =
TableDescriptorBuilder.newBuilder(TABLE_NAME)
+ .setValue(StoreFileTrackerFactory.TRACKER_IMPL,
StoreFileTrackerFactory.Trackers.DEFAULT.name())
Review comment:
I hope we could differentiate brand new clusters from migrating ones, so
that entirely new clusters with FILE tracker enabled globally could benefit
from not having DEFAULT (thus temp dirs and renames) at all. The main reason
here is to safely get rid of hboss, until we have something relying in temp
dirs/renames, we can't safely remove hboss from the picture.
And are you sure the table descriptor is not getting saved upon creation,
then loaded on sub-sequent starts?
[MasterRegion.create](https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/master/region/MasterRegion.java#L326)
seems to just read the table info from file system
[here](https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/master/region/MasterRegion.java#L249).
If so, we could just add the similar check, when loading, to set DEFAULT if no
tracker config is found, whilst setting the global tracker config in the
bootstrap.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
