wchevreuil commented on a change in pull request #4009:
URL: https://github.com/apache/hbase/pull/4009#discussion_r780295782



##########
File path: 
hbase-server/src/main/java/org/apache/hadoop/hbase/master/region/MasterRegionFactory.java
##########
@@ -83,6 +84,7 @@
   public static final byte[] PROC_FAMILY = Bytes.toBytes("proc");
 
   private static final TableDescriptor TABLE_DESC = 
TableDescriptorBuilder.newBuilder(TABLE_NAME)
+    .setValue(StoreFileTrackerFactory.TRACKER_IMPL, 
StoreFileTrackerFactory.Trackers.DEFAULT.name())

Review comment:
       >No, we will not read table info from file system, it is just a region, 
not a table, when calling the method we pass a TableDescriptor in.
   
   Yeah, just looked at `MasterRegion.bootstrap` method. Maybe we could persist 
the TD, since we already have a table dir anyways?
   
   >Or another option is to hard coded to use FILE implementation for master 
local region, as it can also work for HDFS, not big harm. Then we need to do 
the migration at start up for an existing cluster.
   
   I guess that would work too. 
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to