ndimiduk commented on a change in pull request #4024:
URL: https://github.com/apache/hbase/pull/4024#discussion_r791098791
##########
File path:
hbase-common/src/main/java/org/apache/hadoop/hbase/trace/HBaseSemanticAttributes.java
##########
@@ -38,14 +38,13 @@
public static final AttributeKey<String> TABLE_KEY =
AttributeKey.stringKey("db.hbase.table");
public static final AttributeKey<List<String>> REGION_NAMES_KEY =
AttributeKey.stringArrayKey("db.hbase.regions");
- public static final AttributeKey<String> RPC_SERVICE_KEY =
- AttributeKey.stringKey("db.hbase.rpc.service");
- public static final AttributeKey<String> RPC_METHOD_KEY =
- AttributeKey.stringKey("db.hbase.rpc.method");
+ public static final AttributeKey<String> RPC_SYSTEM =
SemanticAttributes.RPC_SYSTEM;
Review comment:
I prefer it here because it keeps the scope of our tracing interface
collected in one place. However, I'm also neutral here and don't mind importing
`SemanticAttributes` directly instead of using this alias.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
