ndimiduk commented on a change in pull request #4024:
URL: https://github.com/apache/hbase/pull/4024#discussion_r791113997



##########
File path: 
hbase-client/src/test/java/org/apache/hadoop/hbase/client/trace/hamcrest/SpanDataMatchers.java
##########
@@ -46,6 +48,18 @@ private SpanDataMatchers() { }
     };
   }
 
+  public static <T extends Comparable<T> & TemporalAmount> Matcher<SpanData> 
hasDuration(
+    Matcher<T> matcher
+  ) {
+    return new FeatureMatcher<SpanData, T>(matcher, "SpanData having duration 
that ", "duration") {
+      @Override
+      @SuppressWarnings("unchecked")
+      protected T featureValueOf(SpanData item) {

Review comment:
       Sure, good point. I guess the `T extends Comparable<T> & TemporalAmount` 
stuff is overly broad.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to