bbeaudreault commented on a change in pull request #4088:
URL: https://github.com/apache/hbase/pull/4088#discussion_r800071455
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/CallRunner.java
##########
@@ -222,6 +223,7 @@ public void drop() {
call.setResponse(null, null, CALL_DROPPED_EXCEPTION, "Call dropped,
server "
+ (address != null ? address : "(channel closed)") + " is overloaded,
please retry.");
call.sendResponseIfReady();
+ this.rpcServer.getMetrics().exception(CALL_DROPPED_EXCEPTION);
Review comment:
As far as I can tell, we do not report them. We added this exception in
https://issues.apache.org/jira/browse/HBASE-26623, but the problem is when we
drop a call here it doesn't end up hitting any of the other invocations of this
method. So the value is always 0 despite throwing these exceptions to clients.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
