bbeaudreault commented on a change in pull request #4088:
URL: https://github.com/apache/hbase/pull/4088#discussion_r800072066
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/CallRunner.java
##########
@@ -222,6 +223,7 @@ public void drop() {
call.setResponse(null, null, CALL_DROPPED_EXCEPTION, "Call dropped,
server "
+ (address != null ? address : "(channel closed)") + " is overloaded,
please retry.");
call.sendResponseIfReady();
+ this.rpcServer.getMetrics().exception(CALL_DROPPED_EXCEPTION);
Review comment:
Typically this is called in a few places, for example in
[RpcServer](https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java#L456)
or in a few try/catches in RSRpcServices. But a couple exceptions need to be
handled a level above this. For example CallQueueTooBigException is [handled in
the
connection](https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/ServerRpcConnection.java#L647)
and RequestTooBig in the [netty frame
decoder](https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/NettyRpcFrameDecoder.java#L134).
So this exception is another example of a special case like
CallQueueTooBig/RequestTooBig, that doesn't get handled by the default
try/catches we have in RpcServer/RSRpcServices.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
