ndimiduk commented on pull request #4126:
URL: https://github.com/apache/hbase/pull/4126#issuecomment-1054362447


   @Apache9 
   
   > I think the problem here is that we forget to end the span created in 
ServerRpcConnection?
   
   I see that the trace scope is closed properly, but I think you're correct 
that the trace is not ended, neither with success nor failure.
   
   > Anyway, I think we should have a big span to trace the whole rpc 
processing...
   
   My impression was that this span in `processRequest` is the big span to 
trace the whole rpc processing. Is there additional scope you would see 
included?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to