Apache9 commented on a change in pull request #4126:
URL: https://github.com/apache/hbase/pull/4126#discussion_r819450672
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/ServerRpcConnection.java
##########
@@ -716,14 +717,22 @@ public String get(RPCTInfo carrier, String key) {
ServerCall<?> call = createCall(id, this.service, md, header, param,
cellScanner,
totalRequestSize, this.addr, timeout, this.callCleanup);
- if (!this.rpcServer.scheduler.dispatch(new CallRunner(this.rpcServer,
call))) {
+ if (this.rpcServer.scheduler.dispatch(new CallRunner(this.rpcServer,
call, span))) {
+ // unset span do that it's not closed in the finally block
+ span = null;
Review comment:
Yes, the code structure here is not friendly for tracing...
Thanks for the detailed comments!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
