[
https://issues.apache.org/jira/browse/HBASE-26814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17503816#comment-17503816
]
Bryan Beaudreault commented on HBASE-26814:
-------------------------------------------
Hah [~apurtell] I was literally just typing up a very similar comment. I don't
think it's worth adding another configuration option just to add that log.
Also, the StoreHotnessProtector's efforts are not totally free, so it feels
wasteful to do all of the management necessary but then no-op the mitigation.
I'm thinking of instead adding a log in init(Configuration conf) which would
log once on startup (or onConfigurationChange). This way someone might still
notice the message on startup if they were looking around for perf issues.
Thoughts? I know we don't do that often, so I could be convinced to just make
it silent.
> Default StoreHotnessProtector to off, with logs to guide when to turn it on
> ---------------------------------------------------------------------------
>
> Key: HBASE-26814
> URL: https://issues.apache.org/jira/browse/HBASE-26814
> Project: HBase
> Issue Type: Improvement
> Reporter: Bryan Beaudreault
> Priority: Major
> Fix For: 2.5.0, 2.6.0, 3.0.0-alpha-3
>
>
> As discussed in HBASE-26522 and somewhat in HBASE-26575,
> StoreHotnessProtector is too conservative. One can easily trigger
> RegionTooBusyException on an otherwise idle regionserver with relatively
> small amount of traffic. The idea behind this protection is good, but it
> needs to take into account current load in order to warrant being enabled by
> default.
> Until it's improved as such, we should change it to default off. One thing we
> can do to help drive usage would be to add warning logs when it would have
> triggered. Operators who are diagnosing performance issues will naturally
> look at the logs and see indication of a potential tool for mitigation.
> cc [[email protected]]
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
