[
https://issues.apache.org/jira/browse/HBASE-26814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17504259#comment-17504259
]
Bryan Beaudreault commented on HBASE-26814:
-------------------------------------------
Yes, that is as intended. The goal here was to only log the message
approximately once per regionserver life. I added a comment about this in the
declaration of loggedDisableMessage. We only added the log so that there might
be some trail at all for an operator to follow if trying to diagnose issues
with write pressure. init() gets called every time a region is onlined. It's
way too much to log this for every single region open. I could have
alternatively added a single check somewhere in the HRegionServer constructor
maybe, but IMO the simplicity of keeping this all in one class is more
beneficial especially given the comment i added.
> Default StoreHotnessProtector to off, with logs to guide when to turn it on
> ---------------------------------------------------------------------------
>
> Key: HBASE-26814
> URL: https://issues.apache.org/jira/browse/HBASE-26814
> Project: HBase
> Issue Type: Improvement
> Reporter: Bryan Beaudreault
> Assignee: Bryan Beaudreault
> Priority: Major
> Fix For: 2.5.0, 2.6.0, 3.0.0-alpha-3
>
>
> As discussed in HBASE-26522 and somewhat in HBASE-26575,
> StoreHotnessProtector is too conservative. One can easily trigger
> RegionTooBusyException on an otherwise idle regionserver with relatively
> small amount of traffic. The idea behind this protection is good, but it
> needs to take into account current load in order to warrant being enabled by
> default.
> Until it's improved as such, we should change it to default off. One thing we
> can do to help drive usage would be to add warning logs when it would have
> triggered. Operators who are diagnosing performance issues will naturally
> look at the logs and see indication of a potential tool for mitigation.
> cc [[email protected]]
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
