bbeaudreault commented on pull request #4180: URL: https://github.com/apache/hbase/pull/4180#issuecomment-1080925690
@apurtell @ndimiduk for your consideration, my latest commit applies the above todos that I came up with: - Make CallQueueTooBigException extend CallDroppedException - Make CallDroppedException extend a new HBaseServerException, which has a `boolean serverOverloaded` field - Serialization changes in IPCUtils and RemoteWithExtrasException[1] - Clean up all the various `instanceof ServerOverloadedExceptions` to use a new `HBaseServerException.isServerOverloaded(t)` [1] The changes in RemoteWithExtrasException aren't the cleanest and may not expand well to many more custom payloads. I think we could improve that if/when any others came. In fact, I think this is much cleaner than the existing [RegionMovedException parsing](https://github.com/apache/hbase/blob/master/hbase-client/src/main/java/org/apache/hadoop/hbase/exceptions/RegionMovedException.java#L72-L110). I could imagine applying a similar change in `instantiateException` for that and still being a lot better off. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
