bbeaudreault commented on pull request #4180: URL: https://github.com/apache/hbase/pull/4180#issuecomment-1081936776
I forgot to address one of your questions: > I agree that "call queue too big/full" is actually an error message (an explanation of the server detailed state that we should not share back to the client, to be honest), not an error behavior/category. Probably this is a message that is sometimes present on some type of "server error" exception type. Can we get rid of the type entirely and instead use some type of "chill and retry" server exception type ? I'd be happy to make a change here, but my only concern is compatibility. I'd really like to land this in branch-2.5, and I don't think (correct me if wrong) we can simply drop these exceptions without a deprecation cycle. But I guess we could mark them both as deprecated here? Also, re-reading this: > "server overloaded" is an awkward part of our API. It's a hint to the client to change its behavior, but is not specific at all. By contrast, HTTP has the [Retry-After header](https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Retry-After) that includes a specific wait interval. **I like this better as a field than an exception class of its own.** Seems like you're satisfied with the current exception here for now then, since I did indeed move it to a field. Agree it'd be cool to add Retry-After in the future. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
