bbeaudreault commented on a change in pull request #4180:
URL: https://github.com/apache/hbase/pull/4180#discussion_r838812466
##########
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionConfiguration.java
##########
@@ -116,6 +142,20 @@
this.writeRpcTimeout = conf.getInt(HConstants.HBASE_RPC_WRITE_TIMEOUT_KEY,
conf.getInt(HConstants.HBASE_RPC_TIMEOUT_KEY,
HConstants.DEFAULT_HBASE_RPC_TIMEOUT));
+
+ long pauseMs = conf.getLong(HBASE_CLIENT_PAUSE,
DEFAULT_HBASE_CLIENT_PAUSE);
+ long pauseMsForServerOverloaded =
conf.getLong(HBASE_CLIENT_PAUSE_FOR_SERVER_OVERLOADED,
+ conf.getLong(HConstants.HBASE_CLIENT_PAUSE_FOR_CQTBE, pauseMs));
+ if (pauseMsForServerOverloaded < pauseMs) {
Review comment:
Ok cool, i wasn't sure what the best way to handle this is. Honestly, i
didn't think about the double-warn, so good catch. What I'll do is remove this
from ConnectionConfiguration here in master. So branch-2x will have this slight
divergence where it needs to have the logic in both classes, in addition to
handling all of the classes in branch-2x that don't exist here anymore.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
