bbeaudreault commented on a change in pull request #4304:
URL: https://github.com/apache/hbase/pull/4304#discussion_r839807025
##########
File path: hbase-shaded/hbase-shaded-client-byo-hadoop/pom.xml
##########
@@ -52,127 +52,13 @@
</plugins>
</build>
<dependencies>
+ <dependency>
+ <groupId>org.apache.hbase</groupId>
+ <artifactId>hbase-shaded-client-provided-dependencies</artifactId>
+ </dependency>
<dependency>
<groupId>org.apache.hbase</groupId>
<artifactId>hbase-client</artifactId>
</dependency>
</dependencies>
-
- <profiles>
Review comment:
these were moved verbatim to hbase-shaded-client-provided-dependencies
so that they actually get included in the dependency reduced pom (since we use
promoteTransitiveDependencies)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
