bbeaudreault commented on pull request #4304: URL: https://github.com/apache/hbase/pull/4304#issuecomment-1085171686
> You can automate making sure we don't duplicate classes or leak unexpected dependencies by doing the same thing hadoop does with the enforcer plugin: > > * https://github.com/apache/hadoop/blob/rel/release-3.3.2/hadoop-client-modules/hadoop-client-check-invariants/pom.xml#L64 > * https://github.com/apache/hadoop/blob/rel/release-3.3.2/hadoop-client-modules/hadoop-client-check-test-invariants/pom.xml#L68 > > (I have not yet found time to start evaluating the implementation here) Thanks! I just checked and actually we do have these checks already. And they actually are protecting us already, i.e. it's what clued me into this issue: https://github.com/apache/hbase/pull/4304#discussion_r839800459. I think maybe what make sense is another litmus test in check-invariants which basically checks for specific classes -- i've found Cell.class, FileSystem.class, and HRegionServer.class to be a good representative of the groupings, but that's by no mean exhaustive. I can look into adding something like this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
