bbeaudreault commented on pull request #4304: URL: https://github.com/apache/hbase/pull/4304#issuecomment-1086936390
Ok this is working and ready for review. In the end, it was easier than I thought: - add byo-hadoop as a dependency of hbase-shaded-mapreduce, and also exclude it from the fat jar - add the same hbase deps provided by byo-hadoop as provided-scope deps. this nullifies the transitive deps for those brought in by hbase-mapreduce, so they are excluded from the jar and the final deps The resulting dependency-reduced-pom.xml includes byo-hadoop and no other hbase dep, as hoped. The resulting hbase-shaded-mapreduce jar shrinks by ~3500 classes relative to branch-2, and i verified that byo-hadoop and mapreduce have no overlapping classes using: - `jar -tf mapreduce.jar | grep -E ".class$" | sort > mapreduce.out` - `jar -tf byo-hadoop.jar | grep -E ".class$" | sort > byo-hadoop.out` - `comm -12 mapreduce.out byo-hadoop.out` This PR does not tackle the hadoop issue at all, I think that one will be harder so I might file a separate jira or totally punt on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
