bbeaudreault edited a comment on pull request #4304: URL: https://github.com/apache/hbase/pull/4304#issuecomment-1086046197
We're looking pretty good here: - hbase-shaded-mapreduce no longer exposes hbase client classes. - Instead it exposes a dependency on hbase-client-shaded-byo-hadoop - Added smoke tests to give protection against classes being added to the wrong jars - Verified that it works in a downstream project Another thing I've done is line-by-line compare byo-hadoop jar contents against mapreduce, expecting no duplicate classes. That check succeeded for hbase-specific classes, but failed for dependencies. I think we need to add some extra exclusions to the hbase-shaded-mapreduce pom. I'm going to work on that and also add the duplicate class check to the invariants script. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
