Apache9 commented on PR #4312:
URL: https://github.com/apache/hbase/pull/4312#issuecomment-1098193565
There is a nasty problem that, if I change the ‘Qualified invocations’ to
always wrap, the new Bootstrap will looks like what you proposed above but then
the single method call will be like this
```
Method createMethod = ClientProtocol.class
.getMethod(
"create",
String.class,
FsPermission.class,
String.class,
EnumSetWritable.class,
boolean.class,
short.class,
long.class,
CryptoProtocolVersion[].class,
String.class);
```
Seems not very natural...
What's more, some calls in the same file will be like this:
```
channel
.pipeline()
.addLast(
```
Seems not very natural too.
So I suppose we only change the first one, i.e, make all the arguments on a
new line, but the method call, we still keep the first one on the same line if
possible. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
