Apache9 commented on PR #4312:
URL: https://github.com/apache/hbase/pull/4312#issuecomment-1098583569
> > Spot checked some files, mostly lgtm but I am not a fan of this
particular change:
>
> Agreed @apurtell , this is one of our points of discussion earlier in the
thread (try to read between the buildbot spam).
I do not get the point here... In the past we DO wrap the method calls like
this
```
a = func(b, c, d, e, f
g, h, i);
```
And in this issue you mentioned you do not like this style
https://issues.apache.org/jira/browse/HBASE-26617
```
protected static final MiniClusterRule miniClusterRule =
MiniClusterRule.newBuilder()
- .setMiniClusterOption(StartMiniClusterOption.builder()
- .numWorkers(3)
- .build())
- .build();
+
.setMiniClusterOption(StartMiniClusterOption.builder().numWorkers(3).build()).build();
```
So you only want to the chained method calls to be one call per line, but
for the arguments, you still want them to keep the old style?
Just let me know. It is just a formatter config change...
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
