BukrosSzabolcs commented on code in PR #4418:
URL: https://github.com/apache/hbase/pull/4418#discussion_r872366680
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/mob/MobFileCleanerChore.java:
##########
@@ -160,17 +160,21 @@ public void cleanupObsoleteMobFiles(Configuration conf,
TableName table) throws
maxCreationTimeToArchive, table);
}
+ FileSystem fs = FileSystem.get(conf);
+ Set<String> regionNames = new HashSet<>();
Path rootDir = CommonFSUtils.getRootDir(conf);
Path tableDir = CommonFSUtils.getTableDir(rootDir, table);
- // How safe is this call?
- List<Path> regionDirs = FSUtils.getRegionDirs(FileSystem.get(conf),
tableDir);
+ List<Path> regionDirs = FSUtils.getRegionDirs(fs, tableDir);
+
+ if(regionDirs != null){
+ regionDirs.stream().forEach(rd -> regionNames.add(rd.getName()));
Review Comment:
You are right. The loop in #173 was re-introduced later and I forgot to
clean this line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
