BukrosSzabolcs commented on code in PR #4418:
URL: https://github.com/apache/hbase/pull/4418#discussion_r872414701


##########
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java:
##########
@@ -1867,6 +1870,10 @@ executorService.new 
ExecutorConfig().setExecutorType(ExecutorType.RS_SNAPSHOT_OP
       choreService.scheduleChore(brokenStoreFileCleaner);
     }
 
+    if (this.rsMobFileCleanerChore != null) {
+      choreService.scheduleChore(rsMobFileCleanerChore);

Review Comment:
   The new MobFileCleanerChore is not the same as the old one. The main cleanup 
is done by the RSMobFileCleanerChore running on each RS, cleaning up mob files 
created by regions hosted on that RS. This should cover most of the usecases.
   But I still had to run a restricted version of the old MobFileCleanerChore 
to clean up after mobs made by now-archived regions, because to make sure those 
are not referenced anymore every hfile have to be checked.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to