wchevreuil commented on code in PR #4418:
URL: https://github.com/apache/hbase/pull/4418#discussion_r875748510
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java:
##########
@@ -1867,6 +1870,10 @@ executorService.new
ExecutorConfig().setExecutorType(ExecutorType.RS_SNAPSHOT_OP
choreService.scheduleChore(brokenStoreFileCleaner);
}
+ if (this.rsMobFileCleanerChore != null) {
+ choreService.scheduleChore(rsMobFileCleanerChore);
Review Comment:
> can only archive mob files created by archived regions (regions no longer
existing in the /data folder). Thanks to this these mob files can no longer be
"currently written" so we do not need the data only available on the RS
Got it.
> The cleaner on the master is wasteful and not especially elegant, but
thanks to the lack of centralized mob tracking we do not have a better way of
collecting the references.
Can we trust META here to list SPLIT/MERGE parents? We could then iterate
through these list and check for mob files for these regions. Just
brainstorming here, ain't sure if the region dir is left lingering in the FS
when SPLIT/MERGE parents are cleared from META (in which case, would make such
alternative unfeasible).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
