[
https://issues.apache.org/jira/browse/HBASE-27026?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tao Li updated HBASE-27026:
---------------------------
Description:
By default Style/FrozenStringLiteralComment is enabled in rubocop. If we update
a ruby file, rubocop prompts `Missing frozen string literal comment` (see
[https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4416/2/artifact/yetus-general-check/output/diff-patch-rubocop.txt)|https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4416/2/artifact/yetus-general-check/output/diff-patch-rubocop.txt].
To address this warn, we need to add `# frozen_string_literal: true` to the top
of the ruby file(see
https://github.com/rubocop/rubocop/blob/master/config/default.yml#L3637), which
will be added to the top of the `Apache License` and will look strange.
I don't think this `FrozenStringLiteralComment` check is very necessary. We can
disable it.
was:
By default Style/FrozenStringLiteralComment is enabled in rubocop. If we update
a ruby file, rubocop prompts `Missing frozen string literal comment` (see
[https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4416/2/artifact/yetus-general-check/output/diff-patch-rubocop.txt)|https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4416/2/artifact/yetus-general-check/output/diff-patch-rubocop.txt].
To address this warn, we need to add `# frozen_string_literal: true` to the top
of the ruby file(see
[https://github.com/rubocop/rubocop/blob/master/config/default.yml#L3631]),
which will be added to the top of the `Apache License` and will look strange.
I don't think this `FrozenStringLiteralComment` check is very necessary. We can
disable it.
> Disable Style/FrozenStringLiteralComment for ruby
> -------------------------------------------------
>
> Key: HBASE-27026
> URL: https://issues.apache.org/jira/browse/HBASE-27026
> Project: HBase
> Issue Type: Task
> Reporter: Tao Li
> Assignee: Tao Li
> Priority: Major
> Attachments: image-2022-05-20-09-14-36-355.png
>
>
> By default Style/FrozenStringLiteralComment is enabled in rubocop. If we
> update a ruby file, rubocop prompts `Missing frozen string literal comment`
> (see
> [https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4416/2/artifact/yetus-general-check/output/diff-patch-rubocop.txt)|https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-4416/2/artifact/yetus-general-check/output/diff-patch-rubocop.txt].
> To address this warn, we need to add `# frozen_string_literal: true` to the
> top of the ruby file(see
> https://github.com/rubocop/rubocop/blob/master/config/default.yml#L3637),
> which will be added to the top of the `Apache License` and will look strange.
> I don't think this `FrozenStringLiteralComment` check is very necessary. We
> can disable it.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
