[
https://issues.apache.org/jira/browse/HBASE-27081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17544699#comment-17544699
]
Duo Zhang commented on HBASE-27081:
-----------------------------------
Tool is not the final rule.
We already know that the tool can not recognize the annotation on methods. It
needs some manual checks, this is the duty of the RM.
So in general, I’m -1 on changing ReplicationLoadSink’s constructor to public.
We do not need to do this.
On the RSGroupInfo I’m OK with restoring the return value but I’m-1 on just
simply removing a UT. For this one I could help providing a PR to fix it.
And on the field in TableDescriptorBuilder and HTableDescriptor, I’m -1 on
restoring them until we hear the voice from the author or the committer, or
someone else can explain what is really going on for that issue.
Thanks.
> Fix disallowed compatibility breaks on branch-2.5 and branch-2
> --------------------------------------------------------------
>
> Key: HBASE-27081
> URL: https://issues.apache.org/jira/browse/HBASE-27081
> Project: HBase
> Issue Type: Bug
> Affects Versions: 2.5.0
> Reporter: Andrew Kyle Purtell
> Assignee: Andrew Kyle Purtell
> Priority: Blocker
> Fix For: 2.5.0
>
>
> Change to Public interfaces without deprecation:
> HTableDescriptor
> Field DEFAULT_NORMALIZATION_ENABLED of type boolean has been removed from
> this class.
> TableDescriptorBuilder
> Field DEFAULT_NORMALIZATION_ENABLED of type boolean has been removed from
> this class.
> RandomRowFilter
> Field random of type java.util.Random has been removed from this class.
> A client program may be interrupted by NoSuchFieldError exception.
> ReplicationLoadSink.ReplicationLoadSink ( long age, long timestamp, long
> timestampStarted, long totalOpsProcessed )
> Access level has been changed from public to private. A client
> program may be interrupted by IllegalAccessError exception.
> RSGroupInfo.getServers:()Ljava/util/Set;
> Return value type has been changed from
> java.util.Set<org.apache.hadoop.hbase.net.Address> to
> java.util.SortedSet<org.apache.hadoop.hbase.net.Address>.
> This method has been removed because the return type is part of the method
> signature. A client program may be interrupted by NoSuchMethodError exception.
> These changes are not allowed by policy for a minor release so I have
> committed fixes on my own authority as RM to branch-2.5 and branch-2. Further
> changes can be pursued on branch-2.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
