[ 
https://issues.apache.org/jira/browse/HBASE-27081?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17544702#comment-17544702
 ] 

Andrew Kyle Purtell commented on HBASE-27081:
---------------------------------------------

The duty of the RM is to make a call. That’s what I have done here. My rule was 
if the finding is flagged as HIGH priority and is a trivial change like a 
removed constant or a changed visibility modifier or a trivial field change, 
then I would revert it. This not the final word, it’s only my proposal for the 
vote. In this case anticipating people may find issues with RCO it is only a 
DISCUSS not a VOTE yet. Happy to review and merge proposals such as the unit 
test fix.

I believe no matter what choices I made here, even leaving it alone, someone 
would raise an issue. And that’s fine. 

> Fix disallowed compatibility breaks on branch-2.5 and branch-2
> --------------------------------------------------------------
>
>                 Key: HBASE-27081
>                 URL: https://issues.apache.org/jira/browse/HBASE-27081
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 2.5.0
>            Reporter: Andrew Kyle Purtell
>            Assignee: Andrew Kyle Purtell
>            Priority: Blocker
>             Fix For: 2.5.0
>
>
> Change to Public interfaces without deprecation:
> HTableDescriptor
> Field DEFAULT_NORMALIZATION_ENABLED of type boolean has been removed from 
> this class.
> TableDescriptorBuilder
> Field DEFAULT_NORMALIZATION_ENABLED of type boolean has been removed from 
> this class.
> RandomRowFilter
> Field random of type java.util.Random has been removed from this class.       
> A client program may be interrupted by NoSuchFieldError exception.
> ReplicationLoadSink.ReplicationLoadSink ( long age, long timestamp, long 
> timestampStarted, long totalOpsProcessed ) 
> Access level has been changed from public to private.         A client 
> program may be interrupted by IllegalAccessError exception.
> RSGroupInfo.getServers:()Ljava/util/Set;
> Return value type has been changed from 
> java.util.Set<org.apache.hadoop.hbase.net.Address> to 
> java.util.SortedSet<org.apache.hadoop.hbase.net.Address>. 
> This method has been removed because the return type is part of the method 
> signature. A client program may be interrupted by NoSuchMethodError exception.
> These changes are not allowed by policy for a minor release so I have 
> committed fixes on my own authority as RM to branch-2.5 and branch-2. Further 
> changes can be pursued on branch-2. 



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

Reply via email to