bbeaudreault commented on code in PR #4533:
URL: https://github.com/apache/hbase/pull/4533#discussion_r906175720
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/util/TableDescriptorChecker.java:
##########
@@ -60,6 +60,17 @@ public final class TableDescriptorChecker {
private TableDescriptorChecker() {
}
+ private static boolean shouldSanityCheck(final Configuration conf, final
TableDescriptor td) {
+ if (conf.getBoolean(TABLE_SANITY_CHECKS, DEFAULT_TABLE_SANITY_CHECKS)) {
+ return true;
+ }
+ String tableVal = td.getValue(TABLE_SANITY_CHECKS);
Review Comment:
I see you sort of pulled this logic from lines 71-79 below, but inverted the
conditions. But I think the way you have it here is now more restrictive and
doesn't allow the table descriptor to override.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
