bbeaudreault commented on code in PR #4533:
URL: https://github.com/apache/hbase/pull/4533#discussion_r906177179
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/util/TableDescriptorChecker.java:
##########
@@ -186,9 +178,18 @@ public static void sanityCheck(final Configuration c,
final TableDescriptor td)
}
// check replication scope
- checkReplicationScope(hcd);
+ try {
Review Comment:
it would be nice to keep these check methods somewhat consistent. You
removed the warnOrThrowExceptionForFailure from the above checks, but added
them here. Can you instead keep it consistent (all here or all in the check
methods)?
That might mean either removing this diff here, or adding back the
try/catches above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
