apurtell commented on code in PR #4634:
URL: https://github.com/apache/hbase/pull/4634#discussion_r929364009
##########
hbase-asyncfs/src/main/java/org/apache/hadoop/hbase/io/asyncfs/FanOutOneBlockAsyncDFSOutput.java:
##########
@@ -252,7 +256,7 @@ private synchronized void failed(Channel channel,
Supplier<Throwable> errorSuppl
// disable further write, and fail all pending ack.
state = State.BROKEN;
failWaitingAckQueue(channel, errorSupplier);
- datanodeInfoMap.keySet().forEach(ChannelOutboundInvoker::close);
+ datanodeInfoMap.keySet().forEach(NettyFutureUtils::safeClose);
Review Comment:
I like the approach here where new `NettyFutureUtils` encapsulates the
await/cleanup details, (edit: and suppresses warnings in one place, mostly.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
