apurtell commented on code in PR #4634:
URL: https://github.com/apache/hbase/pull/4634#discussion_r929367000
##########
hbase-examples/src/main/java/org/apache/hadoop/hbase/client/example/HttpProxyExample.java:
##########
@@ -239,6 +240,7 @@ protected void initChannel(Channel ch) throws Exception {
}).bind(port).syncUninterruptibly().channel();
}
+ @SuppressWarnings("FutureReturnValueIgnored")
Review Comment:
This is example code so ideally we show how to properly manage futures here.
In this case just adding a comment at the top of the file should be good, to
explain the suppressions.
/*
* Future class methods will all return a new Future, so you always have
one future that
* will not been checked, so we need to suppress error-prone
"FutureReturnValueIgnored"
* warnings
*/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
