bbeaudreault commented on PR #4937:
URL: https://github.com/apache/hbase/pull/4937#issuecomment-1368330107

   @apurtell There is currently no json support. This PR was initially to add a 
new json field to the SlowLog protobuf message, which would provide insight 
into the request details for the slow/large request in json format. 
   
   Since we are adding a new feature and have the opportunity to think of 
future compatibility, I was suggesting that we not add a new json field. 
Instead we should add fields which contains the actual request proto. So if the 
slow request was a scan, it'd be stashed in a new `optional Scan scan` field on 
the SlowLog proto. The Admin interface would handle converting to the typical 
client models like we do for everything else.
   
   I actually think this would be far more compatible for the future than a new 
json field. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to