bbeaudreault commented on code in PR #4937:
URL: https://github.com/apache/hbase/pull/4937#discussion_r1063706837
##########
hbase-client/src/main/java/org/apache/hadoop/hbase/shaded/protobuf/ProtobufUtil.java:
##########
@@ -3376,7 +3401,9 @@ private static LogEntry getSlowLogRecord(final
TooSlowLog.SlowLogPayload slowLog
.setQueueTime(slowLogPayload.getQueueTime()).setRegionName(slowLogPayload.getRegionName())
.setResponseSize(slowLogPayload.getResponseSize())
.setServerClass(slowLogPayload.getServerClass()).setStartTime(slowLogPayload.getStartTime())
- .setUserName(slowLogPayload.getUserName()).build();
+
.setUserName(slowLogPayload.getUserName()).setScan(slowLogPayload.getScan())
+ .setMulti(slowLogPayload.getMulti()).setGet(slowLogPayload.getGet())
Review Comment:
We can't expose the actual protos to downstream users. Instead we should use
the correct ProtobufUtil or RequestConverter methods to convert these into the
actual client models here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
