bbeaudreault commented on code in PR #4933:
URL: https://github.com/apache/hbase/pull/4933#discussion_r1065180780
##########
hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/RestoreJob.java:
##########
@@ -32,12 +33,13 @@
public interface RestoreJob extends Configurable {
/**
* Run restore operation
+ * @param targetFileSystem output file system
* @param dirPaths path array of WAL log directories
* @param fromTables from tables
* @param toTables to tables
* @param fullBackupRestore full backup restore
* @throws IOException if running the job fails
*/
- void run(Path[] dirPaths, TableName[] fromTables, TableName[] toTables,
boolean fullBackupRestore)
- throws IOException;
+ void run(FileSystem targetFileSystem, Path[] dirPaths, TableName[]
fromTables,
Review Comment:
nit: looks like dirPaths and fromTables are input related. targetFileSystem
and toTables are output related. can you actually move targetFileSystem to the
3rd param?
##########
hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/RestoreTablesClient.java:
##########
@@ -69,6 +69,12 @@ public RestoreTablesClient(Connection conn, RestoreRequest
request) {
this.isOverwrite = request.isOverwrite();
this.conn = conn;
this.conf = conn.getConfiguration();
+ if (request.getTargetRootDir() != null) {
Review Comment:
I wonder if we should rename this to getRestoreRootDir... just so its
symmetrical with getBackupRootDir
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
