bbeaudreault commented on code in PR #4933:
URL: https://github.com/apache/hbase/pull/4933#discussion_r1069729607


##########
hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/util/BackupUtils.java:
##########
@@ -685,21 +685,20 @@ public static boolean validate(HashMap<TableName, 
BackupManifest> backupManifest
     return isValid;
   }
 
-  public static Path getBulkOutputDir(String tableName, Configuration conf, 
boolean deleteOnExit)
-    throws IOException {
-    FileSystem fs = FileSystem.get(conf);
-    String tmp =
-      conf.get(HConstants.TEMPORARY_FS_DIRECTORY_KEY, fs.getHomeDirectory() + 
"/hbase-staging");
-    Path path = new Path(tmp + Path.SEPARATOR + "bulk_output-" + tableName + 
"-"
+  public static Path getBulkOutputDir(Path restoreRootDir, String tableName, 
Configuration conf,
+    boolean deleteOnExit) throws IOException {
+    FileSystem fs = restoreRootDir.getFileSystem(conf);
+    Path path = new Path(restoreRootDir + Path.SEPARATOR + "bulk_output-" + 
tableName + "-"

Review Comment:
   ```suggestion
       Path path = new Path(restoreRootDir, "bulk_output-" + tableName + "-"
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to