Apache9 commented on PR #4942:
URL: https://github.com/apache/hbase/pull/4942#issuecomment-1378757168

   Oh, we pass null as rsServices in HBASE-15441, so we will not mess up the 
sequence id, so closing the region will not introduce the problem described in 
HBASE-15441 back.
   
   In HBASE-15441, @elliottneilclark said
   
   > Yea, it sure seems like the close isn't needed at all.
   > It tries to:
   > 
   > clean the cache ( something that warmup shouldn't be doing anyway ).
   > Flush all edit ( there should be no edits ever ).
   > Disable all compactions ( there are no compactions running since this is 
read only).
   
   Setting the region to readOnly can prevent the flushing of edits, disabling 
all compactions is no harm.
   
   IIRC, there is a config to control whether we should evict block cache 
entries when closing a region.
   
   Let me check.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to