Apache9 commented on PR #4942:
URL: https://github.com/apache/hbase/pull/4942#issuecomment-1378788918

   EvictOnClose is a global config...
   
   ```
         for (HStoreFile f : result) {
           completionService.submit(new Callable<Void>() {
             @Override
             public Void call() throws IOException {
               boolean evictOnClose =
                 getCacheConfig() != null ? 
getCacheConfig().shouldEvictOnClose() : true;
               f.closeStoreFile(evictOnClose);
               return null;
             }
           });
         }
   ```
   
   I think we could introduce a config here, like 
hbase.hstore.cache.evictblocksonclose. If it is set, we can override the global 
config, if it is not set, we will use the global config. And when wramming up a 
region, we will set this flag to false.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to