[
https://issues.apache.org/jira/browse/HBASE-27539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17679237#comment-17679237
]
Andrew Kyle Purtell edited comment on HBASE-27539 at 1/20/23 5:26 PM:
----------------------------------------------------------------------
[~wchevreuil] The change actually breaks Phoenix so yes, it is a break on an LP
interface which by guidelines we are not supposed to break in patch releases,
and yes, there is a real downstream user of the interface affected. So I think
this change should be reverted from the releasing branches.
Keeping it in branch-2 and master would be fine. We do frequently break LP on
minors and Phoenix in particular has adopted a strategy of maintaining
compatibility modules for our various minor 2.x release lines. They can make a
new compatibility module for a future 2.6 containing this change with only
incremental effort.
was (Author: apurtell):
[~wchevreuil] The change actually breaks Phoenix so yes, it is a break on an LP
interface which by guidelines we are not supposed to break in patch releases,
and there is a real downstream user of the interface affected.
I think this change should be reverted from the releasing branches. Keeping it
in branch-2 and master would be fine. We do frequently break LP on minors and
Phoenix in particular has adopted a strategy of maintaining compatibility
modules for our various minor 2.x release lines. They can make a new
compatibility module for a future 2.6 containing this change with only
incremental effort.
> Encapsulate and centralise access to ref count through StoreFileInfo
> --------------------------------------------------------------------
>
> Key: HBASE-27539
> URL: https://issues.apache.org/jira/browse/HBASE-27539
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 3.0.0-alpha-3
> Reporter: chenglei
> Assignee: chenglei
> Priority: Major
> Fix For: 2.6.0, 3.0.0-alpha-4, 2.5.3
>
>
> Both {{StoreFileReader}} and {{StoreFileInfo}} have a {{refCount}}, and the
> {{refCount}} is currently used in three main ways:
> * When a new {{StoreFileScanner}} is created or close, it increases or
> decreases the {{StoreFileReader.refCount}}.
> * When {{CompactedHFilesDischarger}} checks a {{HStoreFile}} whether it
> could be deleted, it check the {{StoreFileInfo.refCount}}.
> * When {{HStore.getScanners}} gets {{HStoreFile}} from {{StoreFileManager}},
> it increases or decreases the {{StoreFileInfo.refCount}}.
> The problem here is {{StoreFileReader.refCount}} is copied from the
> {{StoreFileInfo.refCount}} and the inconsistent usage of the {{refCount}}
> making the code somewhat hard to understand and causing trace the resource
> race problems such as HBASE-27484 and HBASE-27519 somewhat difficult. I
> suggest we should unify these two {{refCount}} and just use
> {{StoreFileInfo.refCount}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
