taklwu commented on code in PR #5014:
URL: https://github.com/apache/hbase/pull/5014#discussion_r1099715495
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java:
##########
@@ -7280,7 +7280,7 @@ public Map<byte[], List<Path>>
bulkLoadHFiles(Collection<Pair<byte[], String>> f
reqTmp ? null : fs.getRegionDir().toString());
}
Pair<Path, Path> pair = null;
- if (reqTmp) {
+ if (reqTmp || (!StoreFileInfo.isHFile(finalPath))) {
Review Comment:
nit: maybe remove the extra `()` ?
```suggestion
if (reqTmp || !StoreFileInfo.isHFile(finalPath)) {
```
do you have any stacktrace and example of the non-HFile ? also , when you
said `has been split in the bulkload process` , what would this split generate?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
