bbeaudreault commented on code in PR #4536:
URL: https://github.com/apache/hbase/pull/4536#discussion_r1118800870
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/querymatcher/ScanQueryMatcher.java:
##########
@@ -263,9 +263,13 @@ public void clearCurrentRow() {
* Set the row when there is change in row
*/
public void setToNewRow(Cell currentRow) {
- this.currentRow = currentRow;
- columns.reset();
- reset();
+ if (
+ this.currentRow == null || this.rowComparator.compareRows(currentRow,
this.currentRow) != 0
Review Comment:
So now I'm wondering.... what's the functional change here? Seems like you
just moved the comparison into the method, but its all the same. Why do we need
this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
