bbeaudreault commented on code in PR #4536:
URL: https://github.com/apache/hbase/pull/4536#discussion_r1118816524
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java:
##########
@@ -768,7 +768,11 @@ public boolean next(List<Cell> outResult, ScannerContext
scannerContext) throws
// One last chance to break due to size limit. The INCLUDE* cases
above already check
// limit and continue. For the various filtered cases, we need to
check because block
// size limit may have been exceeded even if we don't add cells to
result list.
- if (scannerContext.checkSizeLimit(LimitScope.BETWEEN_CELLS)) {
+ // And when reaching the heartbeat cells, try to return from the loop.
+ if (
+ scannerContext.checkSizeLimit(LimitScope.BETWEEN_CELLS)
+ || kvsScanned % cellsPerHeartbeatCheck == 0
Review Comment:
I wonder actually if all of this can be simplified based on my change in
HBASE-27558 -- What if we just did
`scannerContext.setSizeLimit(ScannerContext.LimitScope.BETWEEN_CELLS,
Long.MAX_VALUE, Long.MAX_VALUE, 100*1024*1024)` in Compactor? Force the
StoreScanner to return every 100mb or so of blocks scanned.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
