[
https://issues.apache.org/jira/browse/HBASE-27681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17695179#comment-17695179
]
Bryan Beaudreault commented on HBASE-27681:
-------------------------------------------
We are allowed to make metric changes like this in minor (not patch) releases,
so for example it should be ok to add this change in 2.6.0 but not 2.5.4. We
should just add a release note.
If we're going to change these, one other change I'd like is to rename
TableLatencies to TableRequests. In
https://issues.apache.org/jira/browse/HBASE-27532, I'm adding
{{blockBytesScanned}} metrics to TableLatencies. Obviously not a latency
metric, but it's the only viable place. So it would potentially be nice to
rebrand this as the place you put metrics related to requests against tables.
> Refactor Table Latency Metrics
> ------------------------------
>
> Key: HBASE-27681
> URL: https://issues.apache.org/jira/browse/HBASE-27681
> Project: HBase
> Issue Type: Improvement
> Reporter: tianhang tang
> Assignee: tianhang tang
> Priority: Major
> Attachments: image-2023-03-01-23-55-14-095.png,
> image-2023-03-01-23-56-16-819.png
>
>
> Benefit:
> # Table Latency Metrics could removed after table has been moved away. Fix
> HBASE-27617
> # Could remove the hash lookup caused by metrics map from the hot request
> path.
> # Reduce the output in jmx. As if we use jmx_exporter to collect metrics to
> Prometheus, the operation overhead of performing regular matching in metric
> is relatively high(especially region metrics, which might be next step).
> # I think that could be the first step after hbase-metrics released. It
> seems that the roadmap indicates that we should replace hadoop-metrics2 with
> hbase-metrics.
> Influence:
> # The metrics structure in jmx will change.
> Old:
> !image-2023-03-01-23-55-14-095.png|width=450,height=407!
> New:
> !image-2023-03-01-23-56-16-819.png|width=615,height=479!
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
