[ 
https://issues.apache.org/jira/browse/HBASE-27681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17697958#comment-17697958
 ] 

Bryan Beaudreault commented on HBASE-27681:
-------------------------------------------

Pushed to master and branch-2. Thanks for the contribution [~tangtianhang]!

[~mrzhao] you're correct that this should resolve HBASE-27486. However, we made 
a change to the metric names, which means we cannot backport to older 2.x 
releases (2.4, 2.5) due to our compatibility requirements. This fix will come 
in whenever 2.6.0 is released. Since you submitted that jira, we could resolve 
it now if you want or we could keep it open until someone decides to provide a 
solution for those active releases.

It could theoretically be possible to provide a backport of this Jira to 
2.4/2.5, without the metric rename stuff. It'd require a bit of work though and 
make the release note confusing, so I don't think we'll do that in this jira.

> Refactor Table Latency Metrics
> ------------------------------
>
>                 Key: HBASE-27681
>                 URL: https://issues.apache.org/jira/browse/HBASE-27681
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: tianhang tang
>            Assignee: tianhang tang
>            Priority: Major
>             Fix For: 2.6.0, 3.0.0-alpha-4
>
>         Attachments: image-2023-03-01-23-55-14-095.png, 
> image-2023-03-01-23-56-16-819.png
>
>
> Benefit:
>  # Table Latency Metrics could removed after table has been moved away. Fix 
> HBASE-27617
>  # Could remove the hash lookup caused by metrics map from the hot request 
> path.
>  # Reduce the output in jmx. As if we use jmx_exporter to collect metrics to 
> Prometheus, the operation overhead of performing regular matching in metric 
> is relatively high(especially region metrics, which might be next step).
>  # I think that could be the first step after hbase-metrics released. It 
> seems that the roadmap indicates that we should replace directly use 
> hadoop-metrics2 with hbase-metrics.
> Influence:
>  # The metrics structure in jmx will change.
> Old:
> !image-2023-03-01-23-55-14-095.png|width=450,height=407! 
> New:
> !image-2023-03-01-23-56-16-819.png|width=615,height=479!



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to