thangTang commented on PR #5072: URL: https://github.com/apache/hbase/pull/5072#issuecomment-1452006459
> * Should we do anything to unify with TableMetrics/MetricsTableSourceImpl class? I think so. But maybe we can split it into another issue? What do you think? > * Are there any additional tests we should add to verify all the new behavior end-to-end? It's a big change. We might at least want to upload a screenshot or dump of jmx metrics from a real server to prove that all of the expected metrics get updated. I will do some tests and upload, maybe a doc, in this weekend. > I also find a lot of duplication in RSRpcServices. I almost wonder if we should expose a method on HRegion: Glad to make some changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
