thangTang commented on PR #5072:
URL: https://github.com/apache/hbase/pull/5072#issuecomment-1455393155
After removed the null check of `MetricsTableRequests`, found this error in
CI:
```
2023-03-06T10:36:45,112 ERROR
[RS_OPEN_PRIORITY_REGION-regionserver/10.2.174.39:0-0]
coprocessor.CoprocessorHost(420): The coprocessor
org.apache.hadoop.hbase.security.visibility.VisibilityController threw
java.lang.NullPointerException: Cannot invoke
"org.apache.hadoop.hbase.regionserver.metrics.MetricsTableRequests.updateTableWriteQueryMeter(long)"
because the return value of
"org.apache.hadoop.hbase.regionserver.HRegion.getMetricsTableRequests()" is null
java.lang.NullPointerException: Cannot invoke
"org.apache.hadoop.hbase.regionserver.metrics.MetricsTableRequests.updateTableWriteQueryMeter(long)"
because the return value of
"org.apache.hadoop.hbase.regionserver.HRegion.getMetricsTableRequests()" is null
at
org.apache.hadoop.hbase.regionserver.MetricsRegionServer.updateWriteQueryMeter(MetricsRegionServer.java:258)
~[classes/:?]
at
org.apache.hadoop.hbase.regionserver.HRegion.batchMutate(HRegion.java:4711)
~[classes/:?]
at
org.apache.hadoop.hbase.regionserver.HRegion.batchMutate(HRegion.java:4623)
~[classes/:?]
at
org.apache.hadoop.hbase.regionserver.HRegion.mutate(HRegion.java:5116)
~[classes/:?]
at
org.apache.hadoop.hbase.regionserver.HRegion.mutate(HRegion.java:5110)
~[classes/:?]
at
org.apache.hadoop.hbase.regionserver.HRegion.mutate(HRegion.java:5106)
~[classes/:?]
at
org.apache.hadoop.hbase.regionserver.HRegion.lambda$put$11(HRegion.java:3266)
~[classes/:?]
at org.apache.hadoop.hbase.trace.TraceUtil.trace(TraceUtil.java:216)
~[classes/:?]
at
org.apache.hadoop.hbase.regionserver.HRegion.put(HRegion.java:3255)
~[classes/:?]
at
org.apache.hadoop.hbase.security.visibility.DefaultVisibilityLabelServiceImpl.addSystemLabel(DefaultVisibilityLabelServiceImpl.java:218)
~[classes/:?]
at
org.apache.hadoop.hbase.security.visibility.DefaultVisibilityLabelServiceImpl.init(DefaultVisibilityLabelServiceImpl.java:143)
~[classes/:?]
at
org.apache.hadoop.hbase.security.visibility.VisibilityController.initVisibilityLabelService(VisibilityController.java:268)
~[classes/:?]
at
org.apache.hadoop.hbase.security.visibility.VisibilityController.postOpen(VisibilityController.java:258)
~[classes/:?]
at
org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost$2.call(RegionCoprocessorHost.java:511)
~[classes/:?]
at
org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost$2.call(RegionCoprocessorHost.java:508)
~[classes/:?]
at
org.apache.hadoop.hbase.coprocessor.CoprocessorHost$ObserverOperationWithoutResult.callObserver(CoprocessorHost.java:558)
~[classes/:?]
at
org.apache.hadoop.hbase.coprocessor.CoprocessorHost.execOperation(CoprocessorHost.java:631)
~[classes/:?]
at
org.apache.hadoop.hbase.regionserver.RegionCoprocessorHost.postOpen(RegionCoprocessorHost.java:508)
~[classes/:?]
at
org.apache.hadoop.hbase.regionserver.HRegion.initializeRegionInternals(HRegion.java:1101)
~[classes/:?]
at
org.apache.hadoop.hbase.regionserver.HRegion.initialize(HRegion.java:955)
~[classes/:?]
at
org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:7724)
~[classes/:?]
at
org.apache.hadoop.hbase.regionserver.HRegion.openHRegionFromTableDir(HRegion.java:7679)
~[classes/:?]
at
org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:7654)
~[classes/:?]
at
org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:7613)
~[classes/:?]
at
org.apache.hadoop.hbase.regionserver.HRegion.openHRegion(HRegion.java:7569)
~[classes/:?]
at
org.apache.hadoop.hbase.regionserver.handler.AssignRegionHandler.process(AssignRegionHandler.java:136)
~[classes/:?]
at
org.apache.hadoop.hbase.executor.EventHandler.run(EventHandler.java:100)
~[classes/:?]
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136)
~[?:?]
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635)
~[?:?]
at java.lang.Thread.run(Thread.java:833) ~[?:?]
```
That's because `Coprocessor` inited earlier than `MetricsTableRequests`.
So I just removed region null check and put MetricsTableRequests null check
back.
Considering that the previous code also has non-empty check on
`tableMetrics` and `tableName`, I don't think this will be worse.
And thank you for providing me the informations about Meter metrics!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
