bbeaudreault commented on PR #5067: URL: https://github.com/apache/hbase/pull/5067#issuecomment-1460444568
@Apache9 any chance you have some time to review this metrics PR? mostly boilerplate. There are some spotbugs/checkstyle warnings, but they all are unrelated to my changes. For example, checkstyle doesn't like the code style of ServerSideScanMetrics where we expose public instance variables, but I can't change that here. And spotbugs doesn't like how MetricsUserSourceImpl has some weird synchronization for the LossyCounting stuff. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
