bbeaudreault commented on code in PR #5067:
URL: https://github.com/apache/hbase/pull/5067#discussion_r1131485819
##########
hbase-hadoop-compat/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsUserSourceImpl.java:
##########
@@ -116,7 +119,7 @@ public MetricsUserSourceImpl(String user,
MetricsUserAggregateSourceImpl agg) {
this.user = user;
this.registry = agg.getMetricsRegistry();
- this.userNamePrefix = "user_" + user + "_metric_";
+ this.userNamePrefix = "User_" + user + "_metric_";
Review Comment:
this change is ok because all of the existing `newTimeHistogram` calls
already capitalize the first letter. So these end up in JMX like
`User_foo_metric_...`. But `newCounter` doesn't do the same capitalization, so
the new blockBytesScannedCount ends up `user_foo_metric_blockBytesScannedCount`
(lowercase u). So this change here just ensures that all the metrics are
similarly capitalized.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
