virajjasani commented on PR #5119:
URL: https://github.com/apache/hbase/pull/5119#issuecomment-1480666627

   > Oh, there is a data race if we also call cleanOldLogs in closeExecutor...
   > 
   > Let me think how to better fix this, maybe a simple synchronized is enough 
as cleanOldLogs are all in memory operations after we introduced a special 
thread pool for archiving.
   
   Okk, was this the only change `private synchronized void cleanOldLogs()`?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to