Apache9 commented on PR #5119: URL: https://github.com/apache/hbase/pull/5119#issuecomment-1480703902
> > Oh, there is a data race if we also call cleanOldLogs in closeExecutor... > > Let me think how to better fix this, maybe a simple synchronized is enough as cleanOldLogs are all in memory operations after we introduced a special thread pool for archiving. > > Okk, was this the only change `private synchronized void cleanOldLogs()`? Yes, I added more comments for this method to explain why we need synchronized here. The failed UT is TestFuzzyRowFilterEndToEnd, which is not related. Let me trigger the UT again to confirm that there are no new flaky UTs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
