bsglz commented on PR #5171:
URL: https://github.com/apache/hbase/pull/5171#issuecomment-1503381441

   Checked the code, the bloom filter use empty family both in storing and 
checking, so seems ok. 
   
   ```
    case ROWCOL:
           if (!scan.isGetScan()) {
             return true;
           }
           if (columns != null && columns.size() == 1) {
             byte[] column = columns.first();
             // create the required fake key
             Cell kvKey = PrivateCellUtil.createFirstOnRow(row, 
HConstants.EMPTY_BYTE_ARRAY, column);
             return passesGeneralRowColBloomFilter(kvKey);
           }
   
           // For multi-column queries the Bloom filter is checked from the
           // seekExact operation.
           return true;
   ```
   ```
   /**
    * An hash key for ROWCOL bloom. This assumes the cells to be serialized in 
the Keyvalue
    * serialization format with Empty column family. Note that the byte 
representing the family length
    * is considered to be 0
    */
   @InterfaceAudience.Private
   public class RowColBloomHashKey extends CellHashKey {
   ```
   BTW, the method of checkGeneralBloomFilter use CellComparator.getInstance() 
directly which return CellComparatorImpl, will change them later.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to