bsglz commented on PR #5171:
URL: https://github.com/apache/hbase/pull/5171#issuecomment-1511073020
Test report for normal cells, used on region level for comping cells among
stores(it is a bit strange new code is even faster than old code, tested many
round and the result are similar):
<html xmlns:x="tencent"><meta charset="utf-8"><style type='text/css'><!-- td
{
empty-cells:show;line-height:normal;color:#000;vertical-align:middle;outline-width:0;word-wrap:break-word;word-break:normal;white-space:nowrap;
text-align:left;font-size:10pt; } table { border-collapse: collapse; } font{
white-space: pre-wrap }--></style><body><!--StartFragment-->
compareMethod | leftFam | rightFam | comparator | cost(ms) | diff
-- | -- | -- | -- | -- | --
compareKV | fam | fam1 | CellComparatorOld | 21738 |
compareKV | fam | fam1 | CellComparatorImpl | 22127 | 2.00%
compareKV | fam1 | fam2 | CellComparatorOld | 22369 |
compareKV | fam1 | fam2 | CellComparatorImpl | 21842 | -2.00%
compareBBKV | fam | fam1 | CellComparatorOld | 24735 |
compareBBKV | fam | fam1 | CellComparatorImpl | 21672 | -12.00%
compareBBKV | fam1 | fam2 | CellComparatorOld | 27043 |
compareBBKV | fam1 | fam2 | CellComparatorImpl | 19978 | -26.00%
compareKVVsBBKV | fam | fam1 | CellComparatorOld | 17861 |
compareKVVsBBKV | fam | fam1 | CellComparatorImpl | 24584 | 38.00%
compareKVVsBBKV | fam1 | fam2 | CellComparatorOld | 19993 |
compareKVVsBBKV | fam1 | fam2 | CellComparatorImpl | 25002 | 25.00%
<!--EndFragment--></body></html>
Test report for inner store comparing:
<html xmlns:x="tencent"><meta charset="utf-8"><style type='text/css'><!--
td {
empty-cells:show;line-height:normal;color:#000;vertical-align:middle;outline-width:0;word-wrap:break-word;word-break:normal;white-space:nowrap;
text-align:left;font-size:10pt; } table { border-collapse: collapse; } font{
white-space: pre-wrap }--></style><body><!--StartFragment-->
compareMethod | leftFamLen | rightFamLen | comparator | cost(ms) | diff
-- | -- | -- | -- | -- | --
compareKV | 0 | 0 | CellComparatorOld | 27740 |
compareKV | 0 | 0 | InnerStoreCellComparator | 25998 | -6.00%
compareKV | 0 | 4 | CellComparatorOld | 18520 |
compareKV | 0 | 4 | InnerStoreCellComparator | 16780 | -9.00%
compareKV | 4 | 0 | CellComparatorOld | 18102 |
compareKV | 4 | 0 | InnerStoreCellComparator | 16719 | -8.00%
compareKV | 4 | 4 | CellComparatorOld | 30889 |
compareKV | 4 | 4 | InnerStoreCellComparator | 26371 | -15.00%
compareBBKV | 0 | 0 | CellComparatorOld | 31693 |
compareBBKV | 0 | 0 | InnerStoreCellComparator | 37343 | 18.00%
compareBBKV | 0 | 4 | CellComparatorOld | 22485 |
compareBBKV | 0 | 4 | InnerStoreCellComparator | 18425 | -18.00%
compareBBKV | 4 | 0 | CellComparatorOld | 23300 |
compareBBKV | 4 | 0 | InnerStoreCellComparator | 20074 | -14.00%
compareBBKV | 4 | 4 | CellComparatorOld | 37689 |
compareBBKV | 4 | 4 | InnerStoreCellComparator | 32012 | -15.00%
compareKVVsBBKV | 0 | 0 | CellComparatorOld | 29372 |
compareKVVsBBKV | 0 | 0 | InnerStoreCellComparator | 34191 | 16.00%
compareKVVsBBKV | 0 | 4 | CellComparatorOld | 19915 |
compareKVVsBBKV | 0 | 4 | InnerStoreCellComparator | 16827 | -16.00%
compareKVVsBBKV | 4 | 0 | CellComparatorOld | 21622 |
compareKVVsBBKV | 4 | 0 | InnerStoreCellComparator | 18511 | -14.00%
compareKVVsBBKV | 4 | 4 | CellComparatorOld | 34458 |
compareKVVsBBKV | 4 | 4 | InnerStoreCellComparator | 29005 | -16.00%
<!--EndFragment--></body></html>
We can see in most case the new code is better, and that cases would be
executed more frequently, so seems it is worths to upgrade to the new
implement. @Apache9
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
